Repository navigation
Fine-grained: Support Python 3 unpacking expressions (and fix crash) - #4966
Merged
Merged
Conversation
ilevkivskyi
reviewed
Apr 25, 2018
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Two questions:
- Why do you skip cache in all tests? It would be good to add a comment about this in tests.
- There is a TODO item in
deps.pyafterprocess_lvalue(presumably left by you) that says# TODO: star lvalue. Isn't it something that should be addressed in this PR?
Collaborator
Author
I'm skipping because many of the cache tests aren't very valuable but they'll slow down tests. I'll add a comment about this somewhere.
I'll have a look. |
JukkaL
changed the title
Contributor
|
I suspect this also fixes #3825 |
Member
|
@asottile, no I just tested and that also fails on master. |
Contributor
|
indeed it does, I should try things before pressing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix crash on incompatible dictionary unpack. Fixes #4959.
Work towards #4951.